feat: DH-20769: Use new JS API in useViewportData to retrieve data#2557
Merged
ericlln merged 25 commits intodeephaven:mainfrom Oct 29, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2557 +/- ##
==========================================
+ Coverage 44.08% 44.36% +0.28%
==========================================
Files 764 764
Lines 43078 43104 +26
Branches 11066 11078 +12
==========================================
+ Hits 18990 19125 +135
+ Misses 24041 23963 -78
+ Partials 47 16 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I think the root |
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 28, 2025
bmingles
reviewed
Oct 29, 2025
bmingles
requested changes
Oct 29, 2025
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
I left inline comments about an issue with the useEffect and the package-lock
This reverts commit cf12764.
bmingles
reviewed
Oct 29, 2025
bmingles
reviewed
Oct 29, 2025
bmingles
requested changes
Oct 29, 2025
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Looks good overall. Left a comment about a place where we can consolidate some duplicate code + an assertion to add to a unit test.
bmingles
reviewed
Oct 29, 2025
bmingles
previously approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useViewportDatato acceptViewportSubscriptionOptions. If this is provided and the provided table is not a tree table, the newcreateViewportSubscriptionmethod introduced in feat!: DH-19895: New JS API for requesting data deephaven-core#7178 will be used to retrieve data from the table@deephaven/jsapi-typesto^1.0.0-dev0.40.4